On 09/04/2024 08:45, michael.opdenacker@xxxxxxxxxxx wrote: > From: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxx> > > This adds initial support for the Milk-V Duo S board > (https://milkv.io/duo-s), enabling the serial port and > read-only SD card support, allowing to boot Linux to the > command line. > > Signed-off-by: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxx> > > --- > > Tested with linux-next as of Apr 9, 2024, > using the risc-v "defconfig" configuration. Please include in your tests what submitting patches and your maintainer profile asks you. checkpatch and testing of DTS. Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
