> -----Original Message----- > From: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > Sent: Friday, April 5, 2024 5:10 AM > To: Klymenko, Anatoliy <Anatoliy.Klymenko@xxxxxxx> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > media@xxxxxxxxxxxxxxx; Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx>; Maarten Lankhorst > <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard > <mripard@xxxxxxxxxx>; Thomas Zimmermann <tzimmermann@xxxxxxx>; > David Airlie <airlied@xxxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; > Simek, Michal <michal.simek@xxxxxxx>; Andrzej Hajda > <andrzej.hajda@xxxxxxxxx>; Neil Armstrong > <neil.armstrong@xxxxxxxxxx>; Robert Foss <rfoss@xxxxxxxxxx>; Jonas > Karlman <jonas@xxxxxxxxx>; Jernej Skrabec > <jernej.skrabec@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; > Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley > <conor+dt@xxxxxxxxxx>; Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx> > Subject: Re: [PATCH v3 2/9] drm: xlnx: zynqmp_dpsub: Update live format > defines > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On 21/03/2024 22:43, Anatoliy Klymenko wrote: > > Update live format defines to match DPSUB AV_BUF_LIVE_VID_CONFIG > register > > layout. > > I think this description needs a bit more. Mention that the defines are > not currently used, so we can change them like this without any other > change. > Makes sense. I'll update this. > Tomi > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@xxxxxxx> > > --- > > drivers/gpu/drm/xlnx/zynqmp_disp_regs.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h > b/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h > > index f92a006d5070..fa3935384834 100644 > > --- a/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h > > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h > > @@ -165,10 +165,10 @@ > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_BPC_10 0x2 > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_BPC_12 0x3 > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_BPC_MASK > GENMASK(2, 0) > > -#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_RGB 0x0 > > -#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YUV444 0x1 > > -#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YUV422 0x2 > > -#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YONLY 0x3 > > +#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_RGB (0x0 > << 4) > > +#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YUV444 (0x1 << > 4) > > +#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YUV422 (0x2 << > 4) > > +#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YONLY (0x3 << > 4) > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_MASK > GENMASK(5, 4) > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_CB_FIRST BIT(8) > > #define ZYNQMP_DISP_AV_BUF_PALETTE_MEMORY 0x400 > >
