On 07/04/2024 20:45, Alex G. wrote: > > > On 4/7/24 13:40, Alex G. wrote: >> >> >> On 4/7/24 12:48, Alex G. wrote: >>> On 3/8/24 03:17, Md Sadre Alam wrote: >>>> Add qpic spi nand driver support. The spi nand >>>> driver currently supported the below commands. >>>> >>>> -- RESET >>>> -- READ ID >>>> -- SET FEATURE >>>> -- GET FEATURE >>>> -- READ PAGE >>>> -- WRITE PAGE >>>> -- ERASE PAGE >>>> >>>> Co-developed-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx> >>>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx> >>>> Co-developed-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> >>>> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> >>>> Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx> >>>> --- >>> >>> For the entire series: >>> >>> Tested-by: Alexandru Gagniuc <mr.nuke.me@xxxxxxxxx> >>> >>>> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig >>>> index bc7021da2fe9..63764e943d82 100644 >>>> --- a/drivers/spi/Kconfig >>>> +++ b/drivers/spi/Kconfig >>>> @@ -882,6 +882,14 @@ config SPI_QCOM_QSPI >>>> help >>>> QSPI(Quad SPI) driver for Qualcomm QSPI controller. >>>> +config SPI_QPIC_SNAND >>>> + tristate "QPIC SNAND controller" >> >> Also, don't tristate this. It can be set as CONFIG_QPIC_COMMON=m, which >> will cause the build to fail because you don't have a MODULE_LICENSE(). > > Please disregard my idiotic suggestion here. I meant to make this > comment on the previous patch. > Also not. All of these must be allowed to be a module. If you need dependency between modules, then use documented syntax in the kernel (foo || !foo). Best regards, Krzysztof
