On 07/04/2024 19:48, Alex G. wrote: > On 3/8/24 03:17, Md Sadre Alam wrote: >> Add qpic spi nand driver support. The spi nand >> driver currently supported the below commands. >> >> -- RESET >> -- READ ID >> -- SET FEATURE >> -- GET FEATURE >> -- READ PAGE >> -- WRITE PAGE >> -- ERASE PAGE >> >> Co-developed-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx> >> Co-developed-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> >> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> >> Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx> >> --- > > For the entire series: > > Tested-by: Alexandru Gagniuc <mr.nuke.me@xxxxxxxxx> > >> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig >> index bc7021da2fe9..63764e943d82 100644 >> --- a/drivers/spi/Kconfig >> +++ b/drivers/spi/Kconfig >> @@ -882,6 +882,14 @@ config SPI_QCOM_QSPI >> help >> QSPI(Quad SPI) driver for Qualcomm QSPI controller. >> >> +config SPI_QPIC_SNAND >> + tristate "QPIC SNAND controller" >> + depends on ARCH_QCOM || COMPILE_TEST > > Here, it needs to 'select QPIC_COMMON`. Otherwise it can run into > unresolved symbols: > > : drivers/spi/spi-qpic-snand.o: in function `snandc_set_reg': > drivers/spi/spi-qpic-snand.c:56:(.text+0x484): undefined reference to > `qcom_offset_to_nandc_reg' No, do not select user-visible symbols. If you observe such issues then either stubs are missing or depends on. Best regards, Krzysztof
