On 05/04/2024 21:58, Fabio Estevam wrote: > On Fri, Apr 5, 2024 at 6:24 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > >> But more important, what about USB C connector? > > In a previous attempt, I tried describing the USB connector: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.9-rc2&id=a4dca89fe8a1585af73e362f5f4e3189a00abf8e > > This broke the USB support as reported by Marek, so I had to revert it: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.9-rc2&id=f954785a124e77d4e6bb52cab689a8de447999aa > > Would it be OK if I send a v2 without the USB C connector description > and address your other comments? No, because I think this should be the connector. Look at datasheet of ptn5150 and ptn5110. Aren't both describing similar hardware? Instead adding some sort of hacked-hardware-representation, please investigate why your previous commit broke things. Best regards, Krzysztof