On 30/03/2024 03:02, Klymenko, Anatoliy wrote: >>>> >>> >>> Sorry, I didn't explain properly what I'm trying to achieve. I need to >>> create a DT node property that represents video signal format, one of >>> MEDIA_BUS_FMT_* from include/uapi/linux/media-bus-format.h. It would >> be >>> nice to reuse the same symbolic values in the device tree. What is the >>> best approach here? Should I create a separate header in There is no user of this new header, so I don't agree. Please send either full work or link your other upstreamed patchset. Anything sent as "DO NOT MERGE" does not count because it is not an user. Without the DTS user I claim that you do not bind here anything... >>> include/dt-bindings with the same or similar (to avoid multiple >>> definition errors) defines, or is it better to create a symlink to >>> media-bus-format.h like include/dt-bindings/linux-event-codes.h? Copying or symlinking entire header into bindings does not help us to understand what is exactly a binding here. For example, maybe you encode runtime information into DT (don't do this) and that's why you need these defines... Or maybe your block has some capabilities. Dunno, patch was not tested, is defined as do not merge and is not explaining any of these. Therefore, please provide complete set of users ready to be merged, test your patches, provide rationale why this is supposed to be a binding and why do you think it represents hardware configuration, not OS policy or runtime configuration. Best regards, Krzysztof
