On 23/03/2024 11:56, Alex Bee wrote: > Hi Krzysztof, > > Am 23.03.24 um 11:32 schrieb Krzysztof Kozlowski: >> On 23/03/2024 09:58, Alex Bee wrote: >>> Add DT binding document for Rockchip's RK816 PMIC >>> >>> Signed-off-by: Alex Bee <knaerzche@xxxxxxxxx> >>> --- >>> changes since v1: >>> - lowercase/hyphens for regulator node names >>> - rename "-reg" to "-regulator" to make node names generic >> I don't understand why did you do it. I did not ask for it. If you want >> to rename, drop redundant regulator or reg suffix from node names. > You didn't ask for that, thats true. > > I did it regardless, since node names should be generic and the "-reg" device node names, here you do not have devices. > suffix is not. They are all subnodes of "regulators", indeed, but I don't > think dropping the suffix completely makes the binding any better, since > there is a boost(-switch) and an otg-switch which are also subnodes of > "regulators" and they are just switches. Adding "regulator" suffix does not make them more generic... anyway, that's not expected pattern. First, do you see such code anywhere? Second, the regulator node names should be usually named as the name of physical component. That's the most common pattern. Please do not bring some exceptions from coding style just for your device. Your device is not special. You did not respond to rest of my comments, so I assume you agree 100% with them. Also, please trim the replies from unneeded context. Best regards, Krzysztof
