Re: [PATCH 1/2] dt-bindings: iio: adc: Add AD4000

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/03/2024 04:29, Marcelo Schmitt wrote:
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4000.example.dtb: adc@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
>> 	from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad4000.yaml#
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4000.example.dtb: adc@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
>> 	from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad4000.yaml#
>>
> 
> ok, adding proper #address-cells and #size-cells fixes the warning.
> 
>   '#address-cells':
>     const: 1
> 
>   '#size-cells':
>     const: 0
> 
> I'm assuming missing those in v1 doesn't hurt review so will wait for some
> feedback before sending a v2.

Hurts in a way it is a proof you did not test your binding before
sending. Performing review on untested code might be a waste of
reviewers time. Please test your code before sending it. I am not going
to perform review of untested code.

It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux