Hi Andrew, > > > + properties: > > + reg: > > + description: > > + "reg indicates the LED group for this LED" > > + enum: [0, 1, 2, 3] > > Having read the code, i don't think the binding needs to say anything > about the group. It is implicit. Port LED 0 is in group 0. Port LED 1 > is in group 1. So there is nothing here which is outside of the > standard LED binding. So as Linus said, i don't think you need any > YAML at all, the DSA port binding should be sufficient. The only purpose for this patch is to limit led numbers to 0-3 and describe that the reg number is the group. If that is not important, I'll just drop it. Regards, Luiz