Hi Krzysztof > On 10/03/2024 05:51, Luiz Angelo Daros de Luca wrote: > > Each port can have up to 4 LEDs (3 for current rtl8365mb devices). The > > LED reg property will indicate its LED group. > > > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC (and consider --no-git-fallback argument). It might > happen, that command when run on an older kernel, gives you outdated > entries. Therefore please be sure you base your patches on recent Linux > kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline), work on fork of kernel > (don't, instead use mainline) or you ignore some maintainers (really > don't). Just use b4 and everything should be fine, although remember > about `b4 prep --auto-to-cc` if you added new patches to the patchset. > > > An example of LED usage was included in an existing switch example. > > > > Cc: devicetree@xxxxxxxxxxxxxxx > > Please drop the autogenerated scripts/get_maintainer.pl CC-entries from > commit msg. There is no single need to store automated output of > get_maintainers.pl in the git log. It can be easily re-created at any > given time, thus its presence in the git history is redundant and > obfuscates the log. It is a left-over before I adopted b4. I'll do the cleanup. > > > +patternProperties: > > + '^(ethernet-)?ports$': > > + type: object > > + additionalProperties: true > > + > > + patternProperties: > > + '^(ethernet-)?port@[0-6]$': > > + type: object > > + additionalProperties: true > > + > > + properties: > > + leds: > > type: object > additionalProperties: false > > > + description: > > + "LEDs associated with this port" > > Drop quotes. At some in my frequent system upgrades (rolling release), it uninstalled the yamllint warning: python package 'yamllint' not installed, skipping It should have catched that before. > > > + > > + patternProperties: > > + '^led@[a-f0-9]+$': > > [0-3] leds are already defined for a port. I'm just trying to add a restriction to allow only 0-3 leds and use that to identify the group. These suggestions will redefine the leds property, forcing me to declare #address-cells, #size-cells for leds and reference the led schema in led@[0-3]. Is there a way to just add a constraint to what is already present? > > > + type: object > > + additionalProperties: true > > This cannot be 'true'. Which then will point you to errors and missing > ref to leds schema and need to use unevaluatedProperties: false. > > > > + > > + properties: > > + reg: > > + description: > > + "reg indicates the LED group for this LED" > > Drop quotes > > > Best regards, > Krzysztof >
