Hi, On Tue, Mar 19, 2024 at 8:29 AM Johan Hovold <johan+linaro@xxxxxxxxxx> wrote: > > Several Qualcomm Bluetooth controllers lack persistent storage for the > device address and instead one can be provided by the boot firmware > using the 'local-bd-address' devicetree property. > > The Bluetooth bindings clearly states that the address should be > specified in little-endian order, but due to a long-standing bug in the > Qualcomm driver which reversed the address some boot firmware has been > providing the address in big-endian order instead. > > The boot firmware in SC7180 Trogdor Chromebooks is known to be affected > so mark the 'local-bd-address' property as broken to maintain backwards > compatibility with older firmware when fixing the underlying driver bug. > > Note that ChromeOS always updates the kernel and devicetree in lockstep > so that there is no need to handle backwards compatibility with older > devicetrees. > > Fixes: 7ec3e67307f8 ("arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt") > Cc: stable@xxxxxxxxxxxxxxx # 5.10 > Cc: Rob Clark <robdclark@xxxxxxxxxxxx> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 ++ > 1 file changed, 2 insertions(+) Assuming DT bindings folks Ack the binding, this looks fine to me. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>