On 12:51-20240314, Chintan Vankar wrote: > +&serdes2 { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; Here and elsewhere Please follow https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node > + serdes2_qsgmii_link: phy@0 { > + reg = <2>; > + cdns,num-lanes = <1>; > + #phy-cells = <0>; > + cdns,phy-type = <PHY_TYPE_QSGMII>; > + resets = <&serdes_wiz2 3>; > + }; > +}; -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D