On 3/12/24 18:09, Sean Anderson wrote: > On 4/10/23 04:20, Richard Alpe wrote: >> Add SFP (Security Fuse Processor) read support for NXP (Freescale) >> QorIQ series SOC's. >> >> This patch adds support for the T1023 SOC using the SFP offset from >> the existing T1023 device tree. In theory this should also work for >> T1024, T1014 and T1013 which uses the same SFP base offset. >> >> Signed-off-by: Richard Alpe <richard@xxxxxxxx> > > This seems like a duplicate of layerscape-sfp.c. The hardware is > (presumably) quite similar, with the T1024RM referencing the QorIQ Trust > Architecture User Guide version 2.0, and the L1046 (e.g.) referencing > version 2.1. > > I think this driver should be removed in favor of the older driver. > There are some problematic bits: most notably no offset is applied by > this driver, so all fuses have an offset of 0x200. So we will need to > implement/document this only for the "fsl,t1023-sfp" compatible, which > has already made its way into the T1023 devicetree... Actually, it seems like the driver was added long after the compatible was added to t1023si-post.dtsi, so maybe we can just change the semantics of the nvmem cell offset. --Sean > This really should have been caught during review; a quick grep for > "SFP" would have revealed the duplication. > > --Sean [Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embeddedworld2024/Register/ew24517689>
