On 02/03/15 10:33, Ray Jui wrote: > +/* > + * Get the clock rate based on name > + */ > +static unsigned long __get_rate(const char *clk_name) > +{ > + struct clk *clk; > + > + clk = __clk_lookup(clk_name); > + if (!clk) { > + pr_err("%s: unable to find clock by name: %s\n", __func__, > + clk_name); > + return 0; > + } > + > + return clk_get_rate(clk); > +} > + This looks like something we should be providing in the core framework. Care to make it into an of_clk_get_parent_rate() API? > +extern void __init iproc_armpll_setup(struct device_node *node); > +extern void __init iproc_pll_setup(struct device_node *node, > + const struct iproc_pll_ctrl *ctrl, > + const struct iproc_pll_vco_freq_param *vco_param, > + unsigned int num_freqs); > +extern void __init iproc_clk_setup(struct device_node *node, > + const struct iproc_clk_ctrl *ctrl, unsigned int num_clks); > +extern void __init iproc_asiu_setup(struct device_node *node, > + const struct iproc_asiu_div *div, > + const struct iproc_asiu_gate *gate, unsigned int num_clks); __init is not necessary in header files. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html