On Tue, 12 Mar 2024 08:49:21 +0800 Yang Xiwen wrote: > >> Still not very correct here. In downstream the core can also have an > >> external PHY. The internal phy is also optional. So maybe this clock > >> should be optional. > > You are responding to yourself 4 min after posting? > > What is the purpose of your comments? > > Just to remind others or myself this can be improved. But i think it's > ready to be applied. There won't be similar design in mainline soon i think. It's a fairly uncommon thing to do, normally such notes should either be comments in the code or notes in the commit message. In any case - the merge window for v6.9 has started, we won't be able to merge these changes for the next 2 weeks :(