Hi Biju, Thanks for your reply. On 2024-03-09 11:54:39 +0000, Biju Das wrote: > > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Sent: Saturday, March 9, 2024 11:41 AM > > Subject: Re: [PATCH] arm64: dts: renesas: white-hawk: ethernet: Describe adv1 and avb2 > > Typo adv1->avb1?? Indeed, will fix. > > Cheers, > Biju > > > > > On 09/03/2024 02:30, Niklas Söderlund wrote: > > > + > > > +&pfc { > > > + avb1_pins: avb1 { > > > + mux { > > > + groups = "avb1_link", "avb1_mdio", "avb1_rgmii", > > > + "avb1_txcrefclk"; > > > + function = "avb1"; > > > + }; > > > + > > > + pins_mdio { > > > > You should not use underscores in node names. > > > > Best regards, > > Krzysztof > > > -- Kind Regards, Niklas Söderlund