Re: [PATCH] arm64: dts: renesas: white-hawk: ethernet: Describe adv1 and avb2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

Thanks for your feedback.

On 2024-03-09 12:41:11 +0100, Krzysztof Kozlowski wrote:
> On 09/03/2024 02:30, Niklas Söderlund wrote:
> > +
> > +&pfc {
> > +	avb1_pins: avb1 {
> > +		mux {
> > +			groups = "avb1_link", "avb1_mdio", "avb1_rgmii",
> > +				 "avb1_txcrefclk";
> > +			function = "avb1";
> > +		};
> > +
> > +		pins_mdio {
> 
> You should not use underscores in node names.

My bad will fix in v2. Where I also as you suggest in the binding patch 
will use a separate mdio node to describe the bus.

-- 
Kind Regards,
Niklas Söderlund




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux