Hi Andrew,
On 2/27/2024 10:34 AM, Karumanchi, Vineeth wrote:
Hi Andrew,
On 2/23/2024 6:56 PM, Andrew Lunn wrote:
It is not specific to AMD versions. All Cadence GEM IP versions have the
capability, but specific vendors might enable or disable it as per their
requirements.
Do you mean it is an option to synthesizer it or not? So although the
basic IP licensed from Cadence has it, a silicon vendor could remove
it?
Regarding that, we are unsure. However, based on observation from all
previous cadence IP's in AMD Soc's, this feature was available.
WOL was previously enabled via the device-tree attribute. Some users
might
not leverage it.
This is not typical. If the hardware supports it, we let the end user
decided if they want to use it or not.
So if all silicon should have it, enable it everywhere. If there is an
option to save some gates and leave it out of the silicon, then we do
need some per device knowledge, or a register which tells us what the
synthesis options where.
I have looked into all config_debug* registers of multiple versions
available with us and there is no mention of WOL. I think we can add
MACB_WOL_CAPS to default_config and advertise in ethtool by default.
Please let me know your suggestions/thoughts.
Adding WOL caps to default_gem_config is not effective.
The individual config is overriding default_config.
I only see enabling WOL by default,
- By default, Advertise magic-packet and ARP in ethtool.
- Always set device_set_wakeup_capable to true.
- "magic-packet" property is no longer useful.
Please let me know your suggestions.
--
🙏 vineeth
