On 05/03/2024 05:13, Peng Fan wrote: >>> + >>> +examples: >>> + # Clock Control Module node: >>> + - | >>> + #include <dt-bindings/clock/nxp,imx95-clock.h> >>> + >>> + syscon@4c410000 { >> >> clock-controller@... > > But this is a syscon, using clock-controller will trigger dt > check warning. Which warning? >> >> As that is the main feature/function. >> >>> + compatible = "nxp,imx95-vpumix-csr", "syscon"; >>> + reg = <0x4c410000 0x10000>; >>> + #clock-cells = <1>; >> >> Please make the example as full as possible. For example, add mux-controller >> node. Do some of the blocks not have mux ctrl? > > Yes. The blk ctrl is not just for clock, some registers has mux ctrl, > such as Pixel_link_sel. Then mux-controller should not be allowed for them. Best regards, Krzysztof