.org; linux-kernel@xxxxxxxxxxxxxxx; Peng Fan > <peng.fan@xxxxxxx> > Subject: Re: [PATCH v3 1/2] dt-bindindgs: clock: support NXP i.MX95 BLK CTL > module > > On Wed, Feb 28, 2024 at 03:48:22PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@xxxxxxx> > > > > i.MX95 includes BLK CTL module in several MIXes, such as VPU_CSR in > > VPUMIX, BLK_CTRL_NETCMIX in NETCMIX, CAMERA_CSR in CAMERAMIX > and etc. > > > > The BLK CTL module is used for various settings of a specific MIX, > > such as clock, QoS and etc. > > > > This patch is to add some BLK CTL modules that has clock features. > > This sentence doesn't add anything you haven't already said. Will drop it. > > > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > > --- > > .../devicetree/bindings/clock/imx95-blk-ctl.yaml | 61 > ++++++++++++++++++++++ > > include/dt-bindings/clock/nxp,imx95-clock.h | 32 ++++++++++++ > > 2 files changed, 93 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/clock/imx95-blk-ctl.yaml > > b/Documentation/devicetree/bindings/clock/imx95-blk-ctl.yaml > > new file mode 100644 > > index 000000000000..c8974b927bee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/imx95-blk-ctl.yaml > > @@ -0,0 +1,61 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +cetree.org%2Fschemas%2Fclock%2Fimx95-blk- > ctl.yaml%23&data=05%7C02%7Cp > > > +eng.fan%40nxp.com%7Cd0a6445fb5604872ec3a08dc3c58e0e9%7C686ea1 > d3bc2b4c > > > +6fa92cd99c5c301635%7C0%7C0%7C638451599621992781%7CUnknown% > 7CTWFpbGZsb > > > +3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn > 0%3D > > > +%7C0%7C%7C%7C&sdata=DJA1dYKc3f9Q5S%2Fa20O%2BJWgQU%2FsMiskY > RIykKzCRUok > > +%3D&reserved=0 > > +$schema: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +cetree.org%2Fmeta- > schemas%2Fcore.yaml%23&data=05%7C02%7Cpeng.fan%40nx > > > +p.com%7Cd0a6445fb5604872ec3a08dc3c58e0e9%7C686ea1d3bc2b4c6fa9 > 2cd99c5c > > > +301635%7C0%7C0%7C638451599622001649%7CUnknown%7CTWFpbGZs > b3d8eyJWIjoiM > > > +C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7 > C%7C%7 > > > +C&sdata=RvMgj7vtwJ3WMYsD3gEO9U8ZI2fRsPy6WVYhCOJ0EfI%3D&reserv > ed=0 > > + > > +title: NXP i.MX95 Block Control > > + > > +maintainers: > > + - Peng Fan <peng.fan@xxxxxxx> > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - nxp,imx95-cameramix-csr > > + - nxp,imx95-display-master-csr > > + - nxp,imx95-dispmix-lvds-csr > > + - nxp,imx95-dispmix-csr > > + - nxp,imx95-netcmix-blk-ctrl > > + - nxp,imx95-vpumix-csr > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > + power-domains: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 1 > > + description: > > + The clock consumer should specify the desired clock by having the > clock > > + ID in its "clocks" phandle cell. See > > + include/dt-bindings/clock/nxp,imx95-clock.h > > + > > + mux-controller: > > + type: object > > + $ref: /schemas/mux/reg-mux.yaml > > + > > +required: > > + - compatible > > + - reg > > + - '#clock-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + # Clock Control Module node: > > + - | > > + #include <dt-bindings/clock/nxp,imx95-clock.h> > > + > > + syscon@4c410000 { > > clock-controller@... But this is a syscon, using clock-controller will trigger dt check warning. > > As that is the main feature/function. > > > + compatible = "nxp,imx95-vpumix-csr", "syscon"; > > + reg = <0x4c410000 0x10000>; > > + #clock-cells = <1>; > > Please make the example as full as possible. For example, add mux-controller > node. Do some of the blocks not have mux ctrl? Yes. The blk ctrl is not just for clock, some registers has mux ctrl, such as Pixel_link_sel. Thanks, Peng.