On Sat, Mar 02, 2024 at 07:38:35PM +0100, Eric Woudstra wrote:
...
> +static int air_led_init(struct phy_device *phydev, u8 index, u8 state, u8 pol)
> +{
> + int val;
> + int err;
> +
> + if (index >= EN8811H_LED_COUNT)
> + return -EINVAL;
Hi Eric,
I think val needs to be initialised before it is used below.
Flagged by clang-17 W=1 build.
> +
> + if (state == AIR_LED_ENABLE)
> + val |= AIR_PHY_LED_ON_ENABLE;
> + else
> + val &= ~AIR_PHY_LED_ON_ENABLE;
> +
> + if (pol == AIR_ACTIVE_HIGH)
> + val |= AIR_PHY_LED_ON_POLARITY;
> + else
> + val &= ~AIR_PHY_LED_ON_POLARITY;
> +
> + err = phy_modify_mmd(phydev, MDIO_MMD_VEND2, AIR_PHY_LED_ON(index),
> + AIR_PHY_LED_ON_ENABLE |
> + AIR_PHY_LED_ON_POLARITY, val);
> +
> + if (err < 0)
> + return err;
> +
> + return 0;
> +}
...
