On 03/02/15 13:17, Sylwester Nawrocki wrote: >> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c >> > index 3d6164e..cf3f0ac 100644 >> > --- a/drivers/clk/samsung/clk-exynos5433.c >> > +++ b/drivers/clk/samsung/clk-exynos5433.c >> > @@ -245,6 +245,8 @@ PNAME(mout_sclk_audio1_p) = { "ioclk_audiocdclk1", "oscclk", >> > PNAME(mout_sclk_audio0_p) = { "ioclk_audiocdclk0", "oscclk", >> > "mout_aud_pll_user_t",}; >> > >> > +PNAME(mout_sclk_hdmi_spdif_p) = { "sclk_audio1", "ioclk_spdif_extclk", }; >> > + >> > static struct samsung_fixed_factor_clock top_fixed_factor_clks[] __initdata = { >> > FFACTOR(0, "oscclk_efuse_common", "oscclk", 1, 1, 0), >> > }; >> > @@ -395,6 +397,10 @@ static struct samsung_mux_clock top_mux_clks[] __initdata = { >> > MUX_SEL_TOP_PERIC1, 4, 2), >> > MUX(CLK_MOUT_SCLK_AUDIO0, "mout_sclk_audio0", mout_sclk_audio0_p, >> > MUX_SEL_TOP_PERIC1, 0, 2), >> > + >> > + /* MUX_SEL_TOP_DISP */ >> > + MUX(CLK_MOUT_SCLK_HDMI_SPDIF, "mout_sclk_hdmi_spdif", >> > + mout_sclk_hdmi_spdif_p, MUX_SEL_TOP_DISP, 0, 1), >> > }; >> > >> > static struct samsung_div_clock top_div_clks[] __initdata = { >> > @@ -1360,6 +1366,11 @@ static struct samsung_gate_clock mif_gate_clks[] __initdata = { >> > ENABLE_SCLK_MIF, 1, CLK_IGNORE_UNUSED, 0), >> > GATE(CLK_SCLK_BUS_PLL_ATLAS, "sclk_bus_pll_atlas", "sclk_bus_pll", >> > ENABLE_SCLK_MIF, 0, CLK_IGNORE_UNUSED, 0), >> > + >> > + /* ENABLE_SCLK_TOP_DISP */ >> > + GATE(CLK_SCLK_HDMI_SPDIF_DISP, "sclk_hdmi_spdif_disp", >> > + "mout_sclk_hdmi_spdif", ENABLE_SCLK_TOP_DISP, 0, >> > + CLK_IGNORE_UNUSED, 0), > > I think this clock should be added to top_gate_clks[] table instead, i.e. > it seems to belong to CMU_TOP, not CMU_MIF. Can you double check it ? > > If you confirm this I will add following change when applying, no need > to resend again: I'm afraid you will need to resend if that change turns out to be needed, since the whole CMU_TOP clock indexing would need to be changed then :/. Or just send a fixup patch on top of both series, adding CLK_SCLK_HDMI_SPDIF_DISP as last CMU_TOP clk index. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html