On Thu, Feb 29, 2024 at 06:55:58PM +0000, Conor Dooley wrote:
> On Tue, Feb 27, 2024 at 03:54:11PM -0500, Frank Li wrote:
> > Some sai only connect one direction. So allow only "rx" or "tx" for
> > dma-names.
>
> Which sai? Can you restrict this per compatible please, so that someone
> cannot add 2 dmas for ones where only the tx is supported.
SAI is exact the same. Only external connect one dma channel.
>
> | dmas:
> | minItems: 1
> | items:
> | - description: DMA controller phandle and request line for RX
> | - description: DMA controller phandle and request line for TX
>
> The binding already allows only one, but it documents that the first dma
> is always the RX dma, and that doesn't change with this patch..
Does below logic work?
anyOf
- enum
- description: ---rx
- description: ---tx
>
> Cheers,
> Conor.
>
> >
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> > Documentation/devicetree/bindings/sound/fsl,sai.yaml | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > index 2456d958adeef..0302752d58a2b 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > @@ -86,10 +86,14 @@ properties:
> > - description: DMA controller phandle and request line for TX
> >
> > dma-names:
> > - minItems: 1
> > - items:
> > - - const: rx
> > - - const: tx
> > + oneOf:
> > + - items:
> > + - const: rx
> > + - const: tx
> > + - items:
> > + - enum:
> > + - rx
> > + - tx
> >
> > interrupts:
> > items:
> >
> > --
> > 2.34.1
> >
