Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework within PSE framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Feb 2024 12:48:01 +0000
Simon Horman <horms@xxxxxxxxxx> wrote:

> On Tue, Feb 27, 2024 at 03:42:55PM +0100, Kory Maincent wrote:
> 
> ...
> 
> > diff --git a/include/linux/pse-pd/pse.h b/include/linux/pse-pd/pse.h
> > index 522115cc6cef..a3e297cc2150 100644
> > --- a/include/linux/pse-pd/pse.h
> > +++ b/include/linux/pse-pd/pse.h
> > @@ -55,10 +55,10 @@ struct pse_controller_ops {
> >  	int (*ethtool_get_status)(struct pse_controller_dev *pcdev,
> >  		unsigned long id, struct netlink_ext_ack *extack,
> >  		struct pse_control_status *status);
> > -	int (*ethtool_set_config)(struct pse_controller_dev *pcdev,
> > -		unsigned long id, struct netlink_ext_ack *extack,
> > -		const struct pse_control_config *config);
> >  	int (*setup_pi_matrix)(struct pse_controller_dev *pcdev);
> > +	int (*pi_is_enabled)(struct pse_controller_dev *pcdev, int id);
> > +	int (*pi_enable)(struct pse_controller_dev *pcdev, int id);
> > +	int (*pi_disable)(struct pse_controller_dev *pcdev, int id);  
> 
> Hi Kory,
> 
> Please update the Kernel doc for struct pse_controller_ops to reflect the
> added and removed fields.

Hello Simon,
Sorry I totally forgot to update the kernel doc on that patch.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux