On Mon, 26 Feb 2024 21:17:06 +0000 Conor Dooley <conor@xxxxxxxxxx> wrote: > On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote: > > On Mon, 26 Feb 2024 16:24:47 +0000 > > Conor Dooley <conor@xxxxxxxxxx> wrote: > > > > > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote: > > > > From: Peng Fan <peng.fan@xxxxxxx> > > > > > > > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268, > > > > so drop it. > > > > > > Don't just remove it from the example, drop it from the binding too? > > > It does permit a 4th "self testing" interrupt. > > > > I'm missing something. See below... > > > > > > Thanks, > > > Conor. > > > > > > > > > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > > > > --- > > > > Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +--- > > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > > > > index dacc526dc695..dfc3f512918f 100644 > > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > > > > @@ -31,7 +31,6 @@ properties: > > > > - description: normal conversion, include EOC (End of Conversion), > > > > ECH (End of Chain), JEOC (End of Injected Conversion) and > > > > JECH (End of injected Chain). > > > > - - description: Self-testing Interrupts. > > > > Eyes skipped over this maybe? The 4th interrupt is removed from binding here... > > Huh, wonder how I missed that. I thought I double checked... > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Cheers, > Conor. Happens to us all! Applied patch 1 to the togreg branch of iio.git and pushed it out as testing so 0-day can poke at it. Thanks, Jonathan
