On 22/02/2024 13:43, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@xxxxxxxxxxx> > > Compared to previous txt based binding doc, the following changes are > made according to the TRM: > > - Remove unmaintained Hi3516 SoC, add Hi3798MV200 > - add MDIO subnode, because MDIO bus is integrated > - add ahb bus clock, phy clock and reset > > Also remove "hisi-femac-v1/2" binding. Where? > > The difference between versions is unknown and not documented anywhere. > Nor is it used in driver. Remove it until it's needed in the future. > > Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx> > --- > .../bindings/net/hisilicon,hisi-femac.yaml | 116 +++++++++++++++++++++ > 1 file changed, 116 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml > new file mode 100644 > index 000000000000..56d7c8a26d0c > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml > @@ -0,0 +1,116 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/hisilicon,hisi-femac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Hisilicon Fast Ethernet MAC controller > + > +maintainers: > + - Yang Xiwen <forbidden405@xxxxxxxxxxx> > + > +allOf: > + - $ref: ethernet-controller.yaml > + > +properties: > + compatible: > + items: > + - enum: > + - hisilicon,hi3798mv200-femac > + - const: hisilicon,hisi-femac If you were re-designing schema, then this should be dropped. No generic compatibles which even the author does not understand what it is. But if you re-use existing binding, then it is a proof that previous commit did something odd. > + > + reg: > + items: > + - description: The first region is the MAC core register base and size. > + - description: The second region is the global MAC control register. > + > + ranges: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: mac > + - const: macif > + - const: phy > + > + resets: > + maxItems: 2 > + > + reset-names: > + items: > + - const: mac > + - const: phy > + > + hisilicon,phy-reset-delays-us: > + items: > + - description: The 1st cell is reset pre-delay in micro seconds. Drop redundant parts: "The 1st cell" and "micro seconds" and instead describe something useful. You have here nine words out of which 7 are redundant or not describing actual property and only two say something. What is "reset pre-delay"? Explain this. > + - description: The 2nd cell is reset pulse in micro seconds. > + - description: The 3rd cell is reset post-delay in micro seconds. > + > +patternProperties: > + '^mdio@[0-9a-f]+$': > + $ref: hisilicon,hisi-femac-mdio.yaml# > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + - phy-connection-type > + - phy-handle > + - hisilicon,phy-reset-delays-us > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + ethernet@9c30000 { > + compatible = "hisilicon,hi3798mv200-femac", "hisilicon,hisi-femac"; > + reg = <0x9c30000 0x1000>, <0x9c31300 0x200>; > + ranges = <0x0 0x9c30000 0x10000>; > + #address-cells = <1>; > + #size-cells = <1>; > + interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk_femac>, > + <&clk_femacif>, > + <&clk_fephy>; > + clock-names = "mac", "macif", "phy"; > + resets = <&crg 0xd0 3>, <&crg 0x388 4>; > + reset-names = "mac", "phy"; > + phy-handle = <&fephy>; > + phy-connection-type = "mii"; > + // To be filled by bootloader > + mac-address = [00 00 00 00 00 00]; > + hisilicon,phy-reset-delays-us = <10000 10000 500000>; > + status = "okay"; Didn't you receive feedback here already? Best regards, Krzysztof
