Re: [PATCH net-next v4 1/6] dt-bindings: net: hisilicon-femac-mdio: convert to YAML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/24/2024 6:01 PM, Krzysztof Kozlowski wrote:
On 22/02/2024 19:19, Yang Xiwen wrote:
On 2/23/2024 2:14 AM, Krzysztof Kozlowski wrote:
On 22/02/2024 13:43, Yang Xiwen via B4 Relay wrote:
From: Yang Xiwen <forbidden405@xxxxxxxxxxx>

For some FEMAC cores, MDIO bus is integrated to the MAC controller. So
We don't have a dedicated MDIO bus clock.
Hm, this means you miss compatibles for these different cores.

So you mean adding a new compatible like
"hisilicon,hisi-femac-mdio-integrated" for these ones without dedicated
clocks?
This is a part of a SoC, right? So compatibles should be SoC specific,
thus I expect some hisilicon,SoC-femac-mdio.


Now i'm very sure the old binding is incorrect. I've downloaded TRM for Hi3516DV300. And found that it is, in fact, very similar to Hi3798MV200. There is no dedicated MDIO bus clock. the MDIO bus clock is always provided by the MAC controller. So here i can say MDIO bus is always integrated into the FEMAC Ethernet controller, not the SoC.


Maybe someday we can merge these two drivers together later. We don't need a MDIO bus node at all!



Best regards,
Krzysztof


--
Regards,
Yang Xiwen





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux