On Fri, Feb 23, 2024 at 09:28:12AM +0100, Linus Walleij wrote: > On Fri, Feb 23, 2024 at 2:08 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote: > > > From: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx> > > > > Add basic implementation of the SCMI v3.2 pincontrol protocol. > > > > Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx> > > Tested-by: Cristian Marussi <cristian.marussi@xxxxxxx> > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx> > > Co-developed-by: Peng Fan <peng.fan@xxxxxxx> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > > This looks ripe for merging for me, there are clearly dependencies in the SCMI > firmware tree so I can't apply this to the pin control tree, but if > someone creates > an immutable branch from the SCMI firmware repo (based off v6.8-rc1 or so) > I'm happy to also pull the branch into pin control. > Well, AFAIK there is another upcoming change in the v3.2 SCMI spec and I am not sure if this series accounts for it...indeed the v3.2 -bet4 was still pending fr feedback AFAIK (and I doubt latest changes are in since they have been discussed like yesterday...)....but I maybe wrong, I will chase for the final spec and look into this to verify if it is compliant... Anyway, given the particularly long history of changes in PINCTRL v3.2 SCMI I would wait to have the final spec officially frozen at this point before merging.... Thanks, Cristian