On Fri, Jan 30, 2015 at 2:17 AM, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> wrote: > This patch adds support to add child devices to gcc as some of the > registers mapped by gcc are used by drivers like thermal sensors. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > --- > drivers/clk/qcom/gcc-msm8960.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c > index 0cd3e26..3ba77c5 100644 > --- a/drivers/clk/qcom/gcc-msm8960.c > +++ b/drivers/clk/qcom/gcc-msm8960.c > @@ -15,6 +15,7 @@ > #include <linux/bitops.h> > #include <linux/err.h> > #include <linux/platform_device.h> > +#include <linux/of_platform.h> > #include <linux/module.h> > #include <linux/of.h> > #include <linux/of_device.h> > @@ -3658,6 +3659,7 @@ static int gcc_msm8960_probe(struct platform_device *pdev) > struct clk *clk; > struct device *dev = &pdev->dev; > const struct of_device_id *match; > + int ret; > > match = of_match_device(gcc_msm8960_match_table, &pdev->dev); > if (!match) > @@ -3677,12 +3679,18 @@ static int gcc_msm8960_probe(struct platform_device *pdev) > if (IS_ERR(clk)) > return PTR_ERR(clk); > > - return qcom_cc_probe(pdev, match->data); > + ret = qcom_cc_probe(pdev, match->data); > + if (ret) > + return ret; > + > + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); How about calling of_syscon_register() instead? That would give us a handle to a regmap that can be consumed in e.g. the thermal driver. I think this use case is exactly why that was introduced. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
