On 22/02/2024 19:13, Yang Xiwen wrote: > On 2/23/2024 2:08 AM, Krzysztof Kozlowski wrote: >> On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote: >>> From: Yang Xiwen <forbidden405@xxxxxxxxxxx> >>> >>> Add "syscon" and "simple-mfd" compatibles to CRG node due to recent >>> binding changes. >> Why? You claimed you added them in the bindings because DTS has them. In >> DTS you claim reason is: binding has them. >> >> That's confusing. > > > Because the old txt based binding claimed there should not be a "syscon" > and "simple-mfd". > > > But it exists in hi3798cv200.dtsi. And i think it does no harm to be > there. So should i do it in two commits? hi3798cv200 is not hi3519, is it? You are adding simple-mfd to one SoC because some other has it? I don't see reason to do that. Er, why? Best regards, Krzysztof
