On 2/23/2024 2:08 AM, Krzysztof Kozlowski wrote:
On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote:
From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
Add "syscon" and "simple-mfd" compatibles to CRG node due to recent
binding changes.
Why? You claimed you added them in the bindings because DTS has them. In
DTS you claim reason is: binding has them.
That's confusing.
Because the old txt based binding claimed there should not be a "syscon"
and "simple-mfd".
But it exists in hi3798cv200.dtsi. And i think it does no harm to be
there. So should i do it in two commits?
Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
---
arch/arm/boot/dts/hisilicon/hi3519.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/hisilicon/hi3519.dtsi b/arch/arm/boot/dts/hisilicon/hi3519.dtsi
index a42b71cdc5d7..da46e01b8fdc 100644
--- a/arch/arm/boot/dts/hisilicon/hi3519.dtsi
+++ b/arch/arm/boot/dts/hisilicon/hi3519.dtsi
@@ -35,7 +35,7 @@ clk_3m: clk_3m {
};
crg: clock-reset-controller@12010000 {
- compatible = "hisilicon,hi3519-crg";
+ compatible = "hisilicon,hi3519-crg", "syscon", "simple-mfd";
Why? This does not make much sense. No children here, no usage as syscon.
Best regards,
Krzysztof
--
Regards,
Yang Xiwen
