Re: [PATCH 2/2] arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add missing USB PHY vbus supply

[Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>]

Am Dienstag, 20. Februar 2024, 16:33:34 CET schrieb Alexander Stein:
> VBUS 5V is statically provided to both USB host and on-bard USB-hub.
> 
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> index c07d59147ab55..5b682dd907578 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> @@ -86,6 +86,10 @@ &usbotg1 {
>  	status = "okay";
>  };
>  
> +&usbphynop1 {
> +	vbus-supply = <&reg_hub_vbus>;
> +};
> +

Okay, this is kinda confusing. While checking imx8mm platform as well, it turns out
vbus-supply in drivers/usb/phy/phy-generic.c is not used at all, because i.MX
chipidea host doesn't use PHY vbus control at all.

Please drop this, thanks.
Alexander

>  &iomuxc {
>  	pinctrl_ecspi1: ecspi1grp {
>  		fsl,pins = <MX8MN_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK	0x00000146>,
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/