> -----Original Message----- > From: Wood Scott-B07421 > Sent: Friday, January 30, 2015 10:44 AM > To: Xie Shaohui-B21989 > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Medve > Emilian-EMMEDVE1 > Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan > > On Thu, 2015-01-29 at 20:38 -0600, Xie Shaohui-B21989 wrote: > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Friday, January 30, 2015 8:54 AM > > > To: shh.xie@xxxxxxxxx > > > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Medve > > > Emilian-EMMEDVE1; Xie Shaohui-B21989 > > > Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan > > > > > > On Wed, 2015-01-28 at 19:54 +0800, shh.xie@xxxxxxxxx wrote: > > > > +- interrupts > > > > + Usage: required > > > > + Value type: <prop-encoded-array> > > > > + Definition: Event interrupt of external MDIO controller. > > > > > > What if this MDIO controller is not "external"? Should Usage say > > > "required for external MDIO"? > > [S.H] I thought the definition can tell the interrupt is for external > > MDIO, I can change the Usage to "required for external MDIO" in next > version. > > how about other parts, are they OK? > > Yes. I'll fix it up when applying. Thank you! Shaohui ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f