Re: [PATCH v7] dt-bindings: mtd: spi-nor: add optional interrupts property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 20.02.24 um 13:19 schrieb Pratyush Yadav:
On Mon, Feb 19 2024, Josua Mayer wrote:

Some spi flash memories have an interrupt signal which can be used for
signalling on-chip events such as busy status or ecc errors to the host.

Add binding for "interrupts" property so that boards wiring this signal
may describe the connection.

Signed-off-by: Josua Mayer <josua@xxxxxxxxxxxxx>
Acked-by: Rob Herring <robh@xxxxxxxxxx>
Acked-by: Pratyush Yadav <pratyush@xxxxxxxxxx>

BTW, I don't see any support in SPI NOR for handling these interrupts.
Do you plan to add them in a later patchset?
No current plans, I have little knowledge how spi-nor works in the kernel.
If not, what do you get by
describing them?
Foremost I get to submit a correct device-tree (describes hardware)
to the kernel, without maintainers getting all over me for introducing
new dtbs_check errors.

And I really do prefer submitting a complete device-tree so that all
knowledge I have gained reading private schematics is readily
available the next time someone works on it.


---
Changes in v7:
- split out of original patchset because it should go via mtd tree
- collected acked-by Rob Herring from v6
- Link to v6: https://lore.kernel.org/r/20240212-add-am64-som-v6-0-b59edb2bc8c3@xxxxxxxxxxxxx
---
  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
index 58f0cea160ef..6e3afb42926e 100644
--- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
+++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
@@ -52,6 +52,9 @@ properties:
      minItems: 1
      maxItems: 2
+ interrupts:
+    maxItems: 1
+
    m25p,fast-read:
      type: boolean
      description:





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux