On 17/02/2024 13:52, Yang Xiwen via B4 Relay wrote: > + > +static const struct hisi_crg_funcs hi3798mv200_sysctrl_funcs = { > + .register_clks = hi3798mv200_sysctrl_clk_register, > + .unregister_clks = hi3798mv200_sysctrl_clk_unregister, > +}; > + > +static const struct of_device_id hi3798mv200_crg_match_table[] = { > + { .compatible = "hisilicon,hi3798mv200-crg", > + .data = &hi3798mv200_crg_funcs }, > + { .compatible = "hisilicon,hi3798mv200-sysctrl", > + .data = &hi3798mv200_sysctrl_funcs }, These are undocumented compatibles. Run checkpatch or properly order your patchset. Best regards, Krzysztof