On 17/02/2024 13:52, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@xxxxxxxxxxx> > > According to the datasheet, some clocks are missing, add their > definitions first. > > Some aliases for hi3798mv200 are also introduced. > > Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx> > --- > include/dt-bindings/clock/histb-clock.h | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/include/dt-bindings/clock/histb-clock.h b/include/dt-bindings/clock/histb-clock.h > index e64e5770ada6..68a53053586a 100644 > --- a/include/dt-bindings/clock/histb-clock.h > +++ b/include/dt-bindings/clock/histb-clock.h > @@ -58,6 +58,27 @@ > #define HISTB_USB3_UTMI_CLK1 48 > #define HISTB_USB3_PIPE_CLK1 49 > #define HISTB_USB3_SUSPEND_CLK1 50 > +#define HISTB_SDIO1_BIU_CLK 51 > +#define HISTB_SDIO1_CIU_CLK 52 > +#define HISTB_SDIO1_DRV_CLK 53 > +#define HISTB_SDIO1_SAMPLE_CLK 54 > +#define HISTB_ETH0_PHY_CLK 55 > +#define HISTB_ETH1_PHY_CLK 56 > +#define HISTB_WDG0_CLK 57 > +#define HISTB_USB2_UTMI0_CLK HISTB_USB2_UTMI_CLK Why? It's anyway placed oddly, the entries are ordered by number/value. > +#define HISTB_USB2_UTMI1_CLK 58 > +#define HISTB_USB3_REF_CLK 59 > +#define HISTB_USB3_GM_CLK 60 > +#define HISTB_USB3_GS_CLK 61 > + > +/* Hi3798MV200 specific clocks */ > + > +// reuse clocks of histb Don't mix comment styles. > +#define HI3798MV200_GMAC_CLK HISTB_ETH0_MAC_CLK > +#define HI3798MV200_GMACIF_CLK HISTB_ETH0_MACIF_CLK > +#define HI3798MV200_FEMAC_CLK HISTB_ETH1_MAC_CLK > +#define HI3798MV200_FEMACIF_CLK HISTB_ETH1_MACIF_CLK > +#define HI3798MV200_FEPHY_CLK HISTB_ETH1_PHY_CLK I don't understand what do you want to achieve here. Clock IDs start from 0 or 1. Best regards, Krzysztof
