Re: [PATCH RFC v3 4/5] phy: hisilicon: hisi-inno-phy: add support for Hi3798MV200 INNO PHY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/20/2024 5:34 AM, Krzysztof Kozlowski wrote:
On 19/02/2024 22:28, Yang Xiwen via B4 Relay wrote:
From: Yang Xiwen <forbidden405@xxxxxxxxxxx>

Direct MMIO resgiter access is used by Hi3798MV200. For other models,
of_iomap() returns 0 due to insufficient length. So they are unaffected.

Also Hi3798MV200 INNO PHY has an extra reset required to be deasserted,
switch to reset_control_bulk_() APIs to resolve this.

Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
---
  drivers/phy/hisilicon/phy-hisi-inno-usb2.c | 65 ++++++++++++++++++------------
  1 file changed, 39 insertions(+), 26 deletions(-)

diff --git a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
index b7e740eb4752..5175e5a351ac 100644
--- a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
+++ b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
@@ -10,6 +10,7 @@
  #include <linux/io.h>
  #include <linux/module.h>
  #include <linux/of.h>
+#include <linux/of_address.h>
  #include <linux/phy/phy.h>
  #include <linux/platform_device.h>
  #include <linux/reset.h>
@@ -43,6 +44,7 @@
  #define PHY_CLK_ENABLE		BIT(2)
struct hisi_inno_phy_port {
+	void __iomem *base;
  	struct reset_control *utmi_rst;
  	struct hisi_inno_phy_priv *priv;
  };
@@ -50,7 +52,7 @@ struct hisi_inno_phy_port {
  struct hisi_inno_phy_priv {
  	void __iomem *mmio;
  	struct clk *ref_clk;
-	struct reset_control *por_rst;
+	struct reset_control *rsts;
This does not look related to this patch at all.
I should emphasize this in commit log. Hi3798MV200 have two resets rather than one. To make things easier, I simply used reset_control_array APIs instead.

  	unsigned int type;
  	struct hisi_inno_phy_port ports[INNO_PHY_PORT_NUM];
  };


Best regards,
Krzysztof


--
Regards,
Yang Xiwen





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux