On Thu, Feb 15, 2024 at 9:20 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Feb 15, 2024 at 12:35 AM Kuninori Morimoto
> <kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> > > This never triggered with "make dtbs_check", because
> > > arch/arm/boot/dts/r8a7778-bockw.dts does not change the status property
> > > of the rcar_sound node to "ok".
> > >
> > > Can we just add a line to do that, or is anything else related to
> > > sound missing in r8a7778-bockw.dts?
> >
> > In my memory, first BockW support used platform-data style
> > (= arch/arm/mach-shmobile/board-bockw.c) but was switched to DT style
> > after that by Ulrich. I don't remember details, but when it switched to
> > DT style, we already focusing to Gen2 board support. So I didn't use it
> > via DT style. I guess he didn't test it, because it is missing many
> > settings to use sound on DT. So, just adding a line is enough anyway.
>
> To clarify: adding the line is enough, or is not enough?
It's missing (at least) pin control.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
