Re: [PATCH] ARM: renesas: r8a7778: add missing reg-name for sound

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert

> > Sound Driver requires "reg-name" to get register info. Current driver
> > try to get register info via "reg" instead of "reg-name" as backup plan,
> > but this support will be removed soon.
> > Use "reg-names" for r8a7778 sound.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> 
> Nice catch!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> i.e. will queue in renesas-devel for v6.9.

Thanks

> Can we just add a line to do that, or is anything else related to
> sound missing in r8a7778-bockw.dts?

In my memory, first BockW support used platform-data style
(= arch/arm/mach-shmobile/board-bockw.c) but was switched to DT style
after that by Ulrich. I don't remember details, but when it switched to
DT style, we already focusing to Gen2 board support. So I didn't use it
via DT style. I guess he didn't test it, because it is missing many
settings to use sound on DT. So, just adding a line is enough anyway.

> I do not have a Bock-W, so I cannot test this.

Same here.

Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux