Hi, On Wed, Feb 14, 2024 at 4:35 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > > -/* This file must be included after sc7180-trogdor.dtsi */ > > > -#include <arm/cros-ec-keyboard.dtsi> > > > +#include "sc7180-trogdor-clamshell.dtsi" > > > > nit: Not that it was terribly consistent before, but in lazor you > > remove the "This file must be included after sc7180-trogdor.dtsi" > > because (I guess) it moved to the clamshell file. However, in other > > dts files you don't remove it. pazquel has the exact same comment and > > it's not removed. Pompom has a slight variant of the comment where it > > explains the reason (to modify cros_ec) and it's not removed. Could > > make it more consistent... > > Sure I can make it more consistent with the explanation. Which way to go > though? Remove it from the boards and put it into the fragment files? I don't care too much. I guess I'd lean toward just putting it in the fragment files just to copy it fewer times. -Doug
