Quoting Doug Anderson (2024-02-13 15:34:38) > Hi, > > On Fri, Feb 9, 2024 at 11:10 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > > + * Copyright 2024 Google LLC. > > + */ > > + > > Tiny nit: should this file have a comment like "/* This file must be > included after sc7180-trogdor.dtsi */" like the clamshell file? I was copying the comment for the keyboard include file, but the detachable doesn't have that include. I can add it here though, that's fine. > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi > > index e9f213d27711..c3fd6760de7a 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi > > @@ -5,8 +5,7 @@ > > * Copyright 2020 Google LLC. > > */ > > > > -/* This file must be included after sc7180-trogdor.dtsi */ > > -#include <arm/cros-ec-keyboard.dtsi> > > +#include "sc7180-trogdor-clamshell.dtsi" > > nit: Not that it was terribly consistent before, but in lazor you > remove the "This file must be included after sc7180-trogdor.dtsi" > because (I guess) it moved to the clamshell file. However, in other > dts files you don't remove it. pazquel has the exact same comment and > it's not removed. Pompom has a slight variant of the comment where it > explains the reason (to modify cros_ec) and it's not removed. Could > make it more consistent... Sure I can make it more consistent with the explanation. Which way to go though? Remove it from the boards and put it into the fragment files?
