Re: [PATCH v11 7/7] iio: adc: adi-axi-adc: move to backend framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2024-02-11 at 18:52 +0200, Andy Shevchenko wrote:
> On Sat, Feb 10, 2024 at 10:57 PM Nuno Sa via B4 Relay
> <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote:
> > 
> > From: Nuno Sa <nuno.sa@xxxxxxxxxx>
> > 
> > Move to the IIO backend framework. Devices supported by adi-axi-adc now
> > register themselves as backend devices.
> 
> ...
> 
> >  struct adi_axi_adc_state {
> >         struct regmap                           *regmap;
> >         struct device                           *dev;
> >  };
> 
> So, not sure you need these two as one can be derived from the other one
> (IIUC).
> In any case, it may be amended in a follow up.

Yeah, I think you're right and I never really thought about it but one can use
regmap_get_device()... 

> 
> ...
> 
> > +       fsleep(10000);
> 
> As I pointed out, the comment is good to have. Maybe you can add it
> when reducing the timeout in a follow up patch...
> 

I did not included because there's no documentation for the delay. But I'll try
to ask around about...

- Nuno Sá





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux