Hi Niklas,
On Tue, Feb 13, 2024 at 1:30 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> On 2024-02-13 09:29:55 +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 13, 2024 at 12:38 AM Niklas Söderlund
> > <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > > On 2024-02-12 20:36:12 +0100, Geert Uytterhoeven wrote:
> > > > On Sat, Jan 27, 2024 at 1:20 PM Niklas Söderlund
> > > > <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > > > > Compatibles can come in two formats. Either "vendor,ip-soc" or
> > > > > "vendor,soc-ip". Add a DT schema file documenting Renesas preferred
> > > > > policy and enforcing it for all new compatibles, except few existing
> > > > > patterns.
> > > > >
> > > > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> > > > > ---
> > > > > * Changes since v1
> > > > > - Split the "SoC agnostic compatibles" section into two to make it's
> > > > > intent clearer.
> > > > > - Improved the documentation for each group of compatibles.
> > > > > - Reduced the number of regexp to create a larger target area. As
> > > > > suggested by Krzysztof the goal is not to validate each SoC name but
> > > > > check for the correct order of SoC-IP.
> > > >
> > > > Thanks for the update!
> > > >
> > > > > --- /dev/null
> > > > > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> > > > > + # Fixed legacy compatibles
> > > > > + #
> > > > > + # List cannot grow with new bindings.
> > > > > + - enum:
> > > > > + - renesas,bsc-r8a73a4
> > > > > + - renesas,bsc-sh73a0
> > > > > + - renesas,dbsc-r8a73a4
> > > > > + - renesas,dbsc3-r8a7740
> > > > > + - renesas,em-gio
> > > > > + - renesas,em-sti
> > > > > + - renesas,em-uart
> > > >
> > > > Perhaps combine these three: "renesas,em-(gpio|sti|usrt)"?
> > >
> > > Will do.
> >
> > That does mean these lines need to use
> >
> > - pattern: "^renesas,em-(gpio|sti|uart)$"
> >
> > right?
>
> Yes, a pattern is needed. I will try to condense the lists as much as
> possible at the cost of strictness as this seems to be the common theme
> in reviewer. This will be,
>
> pattern: "^renesas,em-[a-z0-9]+$"
>
> Or
> pattern: "^renesas,(em|foo|bar|baz)-[a-z0-9]+$"
I'd rather keep these as strict as possible, to make sure no new ones
pop up accidentally. I.e. I prefer "^renesas,em-(gpio|sti|uart)$" over
"^renesas,em-[a-z0-9-]+$".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
