On 2/13/24 08:46, Krzysztof Kozlowski wrote:
The function is not really readable anymore. Please split it into three functions: for v1 (so original code), v2 and wrapper choosing it based on revision). Or two functions and some sort of ops with function pointers (so you call ops->check_clk_period). Or just parametrize the registers with two different "struct reg_field" and use appropriate one for given revision (the code looks the same!) Or just two set of stm32_fmc2_child_props... Anyway the duplicated code just two read different register is it not the way to go.
Hi Krzysztof, As I said in patch 4, I am going to rewrite this patch and I am going to use the platform data to distinguish between each variant instead of checking the IP revision. Regards, Christophe Kerello.
