Hi Roger, On 02/02/24 5:56 pm, Roger Quadros wrote: > > > On 22/01/2024 13:30, MD Danish Anwar wrote: >> The am642-evm doesn't allow to enable 2 x CPSW3g ports and 2 x ICSSG1 ports >> all together, so base k3-am642-evm.dts enables by default 2 x CPSW3g ports >> and 1 x ICSSG1 ports, but it also possible to support 1 x CPSW3g ports and >> 2 x ICSSG1 ports configuration. > > "it is also possible" > > OK so there can only be 3 ethernet ports on this board. There is no "ethernet3" alias. > >> >> This patch adds overlay to support 1 x CPSW3g ports and 2 x ICSSG1 ports >> configuration: >> - Add label name 'mdio_mux_1' for 'mdio-mux-1' node so that the node >> 'mdio-mux-1' can be disabled in the overlay using the label name. >> - disable 2nd CPSW3g port >> - update CPSW3g pinmuxes to not use RGMII2 >> - disable mdio-mux-1 and define mdio-mux-2 to route ICSSG1 MDIO to the >> shared DP83869 PHY >> - add and enable ICSSG1 RGMII2 pinmuxes >> - enable ICSSG1 MII1 port >> >> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx> >> --- >> arch/arm64/boot/dts/ti/Makefile | 5 ++ >> .../dts/ti/k3-am642-evm-icssg1-dualemac.dtso | 75 +++++++++++++++++++ >> arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 +- >> 3 files changed, 81 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am642-evm-icssg1-dualemac.dtso >> >> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile >> index 52c1dc910308..320b2fae5730 100644 >> --- a/arch/arm64/boot/dts/ti/Makefile >> +++ b/arch/arm64/boot/dts/ti/Makefile >> @@ -43,6 +43,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb >> dtb-$(CONFIG_ARCH_K3) += k3-am642-tqma64xxl-mbax4xxl.dtb >> dtb-$(CONFIG_ARCH_K3) += k3-am64-tqma64xxl-mbax4xxl-sdcard.dtbo >> dtb-$(CONFIG_ARCH_K3) += k3-am64-tqma64xxl-mbax4xxl-wlan.dtbo >> +dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-icssg1-dualemac.dtbo >> >> # Boards with AM65x SoC >> k3-am654-gp-evm-dtbs := k3-am654-base-board.dtb k3-am654-base-board-rocktech-rk101-panel.dtbo >> @@ -105,6 +106,8 @@ k3-am642-tqma64xxl-mbax4xxl-sdcard-dtbs := \ >> k3-am642-tqma64xxl-mbax4xxl.dtb k3-am64-tqma64xxl-mbax4xxl-sdcard.dtbo >> k3-am642-tqma64xxl-mbax4xxl-wlan-dtbs := \ >> k3-am642-tqma64xxl-mbax4xxl.dtb k3-am64-tqma64xxl-mbax4xxl-wlan.dtbo >> +k3-am642-evm-icssg1-dualemac-dtbs := \ >> + k3-am642-evm.dtb k3-am642-evm-icssg1-dualemac.dtbo >> k3-j721e-evm-pcie0-ep-dtbs := k3-j721e-common-proc-board.dtb \ >> k3-j721e-evm-pcie0-ep.dtbo >> k3-j721s2-evm-pcie1-ep-dtbs := k3-j721s2-common-proc-board.dtb \ >> @@ -120,6 +123,7 @@ dtb- += k3-am625-beagleplay-csi2-ov5640.dtb \ >> k3-am62a7-sk-csi2-ov5640.dtb \ >> k3-am642-tqma64xxl-mbax4xxl-sdcard.dtb \ >> k3-am642-tqma64xxl-mbax4xxl-wlan.dtb \ >> + k3-am642-evm-icssg1-dualemac.dtb \ >> k3-j721e-evm-pcie0-ep.dtb \ >> k3-j721s2-evm-pcie1-ep.dtb >> >> @@ -129,6 +133,7 @@ DTC_FLAGS_k3-am625-sk += -@ >> DTC_FLAGS_k3-am62-lp-sk += -@ >> DTC_FLAGS_k3-am62a7-sk += -@ >> DTC_FLAGS_k3-am642-tqma64xxl-mbax4xxl += -@ >> +DTC_FLAGS_k3-am642-evm += -@ >> DTC_FLAGS_k3-am6548-iot2050-advanced-m2 += -@ >> DTC_FLAGS_k3-j721e-common-proc-board += -@ >> DTC_FLAGS_k3-j721s2-common-proc-board += -@ >> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm-icssg1-dualemac.dtso b/arch/arm64/boot/dts/ti/k3-am642-evm-icssg1-dualemac.dtso >> new file mode 100644 >> index 000000000000..b2b1a6252e73 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm-icssg1-dualemac.dtso >> @@ -0,0 +1,75 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Don't you need to use updated licensing header like in the series [1] > > [1] https://lore.kernel.org/all/20240110140903.4090946-1-nm@xxxxxx/ > >> +/** >> + * DT overlay for enabling 2nd ICSSG1 port on AM642 EVM >> + * >> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/ >> + */ >> + >> +/dts-v1/; >> +/plugin/; >> + >> +#include <dt-bindings/gpio/gpio.h> >> +#include "k3-pinctrl.h" >> + >> +&{/} { > > You need to fixup alias for ethernet1 to icssg1_emac1? > >> + mdio-mux-2 { > > this should be mdio-mux@0 ? > >> + compatible = "mdio-mux-multiplexer"; >> + mux-controls = <&mdio_mux>; >> + mdio-parent-bus = <&icssg1_mdio>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + mdio@0 { >> + reg = <0x0>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + icssg1_phy2: ethernet-phy@3 { >> + reg = <3>; >> + tx-internal-delay-ps = <250>; >> + rx-internal-delay-ps = <2000>; >> + }; >> + }; >> + }; >> +}; >> + <snip> >> +}; >> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts >> index c08b0223be52..6ae43c12419f 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts >> @@ -200,7 +200,7 @@ mdio_mux: mux-controller { >> mux-gpios = <&exp1 12 GPIO_ACTIVE_HIGH>; >> }; >> >> - mdio-mux-1 { >> + mdio_mux_1: mdio-mux-1 { > > mdio_mux_1: mdio-mux@1 > Changing this from mdio-mux-1 to mdio-mux@1 is giving me erorr in DTBS_CHECK /home/danish/workspace/linux-next/arch/arm64/boot/dts/ti/k3-am642-evm.dtb: /: mdio-mux@1: 'anyOf' conditional failed, one must be fixed: 'reg' is a required property 'ranges' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml# The documentation of mdio-mux-multiplexer [1] also has example section with node name as -1 instead of @1. I don't think node should be renamed to mdio-mux@1. I hadn't done DTBS_CHECK earlier have already made this change in v4 [2]. I will revert back this change and keep the nodes as mdio-mux-1 and mdio-mux-2 in v5. Let me know if it's OK with you. [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/net/mdio-mux-multiplexer.yaml#n34 [2] https://lore.kernel.org/all/20240205090546.4000446-4-danishanwar@xxxxxx/ >> compatible = "mdio-mux-multiplexer"; >> mux-controls = <&mdio_mux>; >> mdio-parent-bus = <&cpsw3g_mdio>; > -- Thanks and Regards, Danish
