Re: [PATCH 0/2] arm64: dts: renesas: rcar-gen4: Correct avb[01] reg sizes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sergey,

On Sun, Feb 11, 2024 at 6:01 PM Sergey Shtylyov <s.shtylyov@xxxxxx> wrote:
> On 2/11/24 5:21 PM, Geert Uytterhoeven wrote:
> > All Ethernet AVB instances on R-Car Gen4 SoCs have registers related to
> > UDP/IP support, starting at offset 0x800.  However, the register blocks
>
>    TCP/UDP/ICMP, actually.

I think you are mixing up Ether AVB on R-Car and GbEth on RZ/G2L...

> > for some (but not all) instances are too small to cover them.
> >
> > This patch series fixes this by extending the register block sizes where
> > needed.  Note that this has no immediate impact on actual operation, as
> > the Linux driver does not use the UDP/IP registers.  Besides, ioremap()
>
>    In fact, it does write to CSR0 at offset 0x800... and in the net-next.git
> the checksum offload is now used.

It only does so on GbEth.
While Ether AVB on R-Car Gen4 has both CSR0 and CSR2 (but no CSR1),
and the register descriptions are the same, the documentation for the
bits is completely different. And later registers differ even more...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux