Re: [PATCH 0/2] arm64: dts: renesas: rcar-gen4: Correct avb[01] reg sizes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/11/24 5:21 PM, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> All Ethernet AVB instances on R-Car Gen4 SoCs have registers related to
> UDP/IP support, starting at offset 0x800.  However, the register blocks

   TCP/UDP/ICMP, actually.

> for some (but not all) instances are too small to cover them.
> 
> This patch series fixes this by extending the register block sizes where
> needed.  Note that this has no immediate impact on actual operation, as
> the Linux driver does not use the UDP/IP registers.  Besides, ioremap()

   In fact, it does write to CSR0 at offset 0x800... and in the net-next.git
the checksum offload is now used.

> granulatity is PAGE_SIZE, so the registers are accessible anyway.

   Ah, indeed, PAGE_SIZE is not less than 0x1000. :-)

> I also considered introducing a new reg tuplet to cover the UDP/IP
> registers.  However, that would complicate handling as some instances
> (on some R-Car Gen2/3 SoCs) already have two reg tuplets, and there are
> no reg-names defined:
> 
>     reg:
>       items:
> 	- description: MAC register block
> 	- description: Stream buffer
> 
> So I think just enlarging the first register block would be fine.

   Yep, thanks! :-)

> To be queued in renesas-devel for v6.9, if you agree.
> 
> Thanks for your comments!
> 
> Geert Uytterhoeven (2):
>   arm64: dts: renesas: r8a779a0: Correct avb[01] reg sizes
>   arm64: dts: renesas: r8a779g0: Correct avb[01] reg sizes
> 
>  arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 4 ++--
>  arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

MBR, Sergey




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux