On Fri, Feb 09, 2024 at 11:17:40PM +0100, Heiko Stübner wrote: > Am Freitag, 9. Februar 2024, 19:17:19 CET schrieb Sebastian Reichel: > > + rockchip,dp-lane-mux: Why "mux" and not "map"? > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 2 > > + maxItems: 4 > > + description: > > + An array of physical Tyep-C lanes indexes. Position of an entry determines > > nit: Type-C lane indexes > > > + the dp lane index, while the value of an entry indicater physical Type-C lane. > > nit: indicates instead of indicater? If we are talking nits, the first use of "dp" should be "DisplayPort (DP)" and s/dp/DP/ elsewhere. > > > + The support dp lanes number are 2 or 4. e.g. for 2 lanes dp lanes map, we could > > nit: The supported dp lane numbers ... ? > > > > + have "rockchip,dp-lane-mux = <2, 3>;", assuming dp lane0 on Type-C phy lane2, > > + dp lane1 on Type-C phy lane3. For 4 lanes dp lanes map, we could have > > + "rockchip,dp-lane-mux = <0, 1, 2, 3>;", assuming dp lane0 on Type-C phy lane0, > > + dp lane1 on Type-C phy lane1, dp lane2 on Type-C phy lane2, dp lane3 on Type-C > > + phy lane3. And > If dp lane map by DisplayPort Alt mode, this property is not need. "If DP lanes are mapped by" "not needed." Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
