On 10/02/2024 02:18, Sebastian Reichel wrote:
> Convert the i.MX6UL touchscreen DT binding to YAML.
>
> Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>
> ---
...
> +
> + interrupts:
> + items:
> + - description: touch controller address
> + - description: ADC2 address
> +
> + clocks:
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: tsc
> + - const: adc
> +
> + xnur-gpio:
xnur-gpios:
Also you need:
maxItems: 1
> + description:
> + The X- gpio this controller connect to. This xnur-gpio returns to
> + low once the finger leave the touch screen (The last touch event
> + the touch controller capture).
> +
> + measure-delay-time:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + The value of measure delay time. Before X-axis or Y-axis measurement,
> + the screen need some time before even potential distribution ready.
> + default: 0xffff
> + minimum: 0
> + maximum: 0xffffff
Time seems like something humans can grasp, so why using hexadecimal
numbers? Same question for pre-charge-time.
> +
> + pre-charge-time:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + The touch screen need some time to precharge.
> + default: 0xfff
> + minimum: 0
> + maximum: 0xffffffff
> +
> + touchscreen-average-samples:
> + description: Number of data samples which are averaged for each read.
This should fail the testing - judging by Rob's reports, you did not
test it. You don't have type for this property. Missing allOf: to
touchscreen.
> + enum: [ 1, 4, 8, 16, 32 ]
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - xnur-gpio
> +
allOf: with $ref to touchscreen.
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/imx6ul-clock.h>
> + #include <dt-bindings/gpio/gpio.h>
> + tsc: tsc@2040000 {
Drop label and just "touchscreen@2040000"
Best regards,
Krzysztof
