On 10/02/2024 02:18, Sebastian Reichel wrote: > Add missing binding for i.MX anatop syscon. > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> > --- > .../bindings/soc/imx/fsl,imx-anatop.yaml | 125 ++++++++++++++++++ > 1 file changed, 125 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml > new file mode 100644 > index 000000000000..436fdae1879e > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml > @@ -0,0 +1,125 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/fsl,imx-anatop.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ANATOP register > + > +maintainers: > + - Shawn Guo <shawnguo@xxxxxxxxxx> > + - Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - fsl,imx6sl-anatop > + - fsl,imx6sll-anatop > + - fsl,imx6sx-anatop > + - fsl,imx6ul-anatop > + - fsl,imx7d-anatop > + - const: fsl,imx6q-anatop > + - const: syscon > + - const: simple-mfd > + - items: > + - const: fsl,imx6q-anatop > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 3 You need to describe items instead (items: - description: ...) > + > + tempmon: > + type: object > + unevaluatedProperties: false > + $ref: /schemas/thermal/imx-thermal.yaml That's confusing. The imx-thermal has phandle to anatop and is a child of it. Please sort it out, e.g. deprecate one way. > + > +patternProperties: > + "regulator-((3p0)|(vddcore)|(vddsoc))$": > + type: object > + unevaluatedProperties: false > + $ref: /schemas/regulator/anatop-regulator.yaml > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/imx6ul-clock.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + anatop: anatop@20c8000 { > + compatible = "fsl,imx6ul-anatop", "fsl,imx6q-anatop", > + "syscon", "simple-mfd"; > + reg = <0x020c8000 0x1000>; > + interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>; > + > + reg_3p0: regulator-3p0 { > + compatible = "fsl,anatop-regulator"; > + regulator-name = "vdd3p0"; Messed indentation. Best regards, Krzysztof
